Open
Conversation
Refactor so that original tags are read to a linked list in a single pass through the FLV. Audio and video flag bytes are also read during this pass so that analysis does not require another pass. Speed improved at least 3x on large files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use Yamdi in a TV archive application used by Universities (www.bobnational.com) and recently updated to 1.9 to fix a long-file duration tag problem. While doing this I noticed that Yamdi traverses the original FLV several times so I have refactored to reduce this to a single traversal for the tags and another for the data. On 2 GB FLVs it was taking about 90 seconds and now it takes about 30.
In case you are interested, I have committed my changes here. The main changes are:
Happy to discuss,
Paul.