Fixed some warning / issues mentioned by SonarLint.#237
Fixed some warning / issues mentioned by SonarLint.#237KingAlex1985 wants to merge 2 commits intoiotaledger-archive:devfrom
Conversation
|
@KingAlex1985 What made you change |
|
Hello @kwek20, ========================================== Rename field "address" (Address.java Line 5) A field should not duplicate the name of its containing class It's confusing to have a class member with the same name (case differences aside) as its enclosing class. Best practice dictates that any field or member with the same name as the enclosing class be renamed ========================================== So that I have decided to name it "AddressHash". Greetings |
Description of change
Please write a summary of your changes and why you made them. Be sure to reference any related issues by adding
fixes # (issue).Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Only by Unit tests, if any existed.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Add an
xto the boxes that are relevant to your changes, and delete any items that are not.