Fixing Release PR#1160
Merged
Merged
Conversation
SgtPooki
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the next release-PR created looks wrong: #1159
This is because
release-pleaseis searching for tag:but it should be looking for
v2.22.0,release-pleasedocumentation does not cover this, but there is this property that is referenced in this issue: googleapis/release-please#1497 and validated in code here: https://github.com/googleapis/release-please/blob/main/src/manifest.ts#L157I added the documentation for future devs whoever is using this action. It's been a nightmare to work with :-/