Merged
Conversation
pelson
force-pushed
the
feature/oe_ae_ligatures
branch
from
ade094f to
21796bd
Compare
Member
|
Ship it ship it, ship it all! Do we need to fix that font build? |
Member
Author
Yup. I had to compromise on font reproducibility by mirroring important metrics from the current font in the new font (this is part of the build script) - the internal FontForge computation is not deterministic when you add new characters to a font otherwise. Unfortunately, this means that I have to build with the same initial conditions as the pipeline, and somehow I've failed to reproduce that (not that I've put any effort into doing so). I'll fix it in a dedicated PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66. Use of AI (ChatGPT) to generate the Œ, æ, œ ligatures