Fix failing pipeline, and validate by adding a dotless j character.#74
Open
pelson wants to merge 4 commits intoipython:masterfrom
Open
Fix failing pipeline, and validate by adding a dotless j character.#74pelson wants to merge 4 commits intoipython:masterfrom
pelson wants to merge 4 commits intoipython:masterfrom
Conversation
… are added locally, they aren't in the old reference OTF so they get committed with raw FontForge bytecode (containing callsubr tokens). On the next CI rebuild those glyphs are in the reference, so the freeze loop inlines their subr calls — producing different bytes from what's committed. The fix adds a second pass after the freeze loop that desubroutinizes all charstrings using the new font's own subr table. New glyphs are normalised on the same local build they're added, so what gets committed is already stable. CI sees inlined charstrings in the reference, _inline_subrs is a no-op, and the bytes are identical.
… re-run earlier ones. Before this the latest stage you could start with was stage 4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also make it possible to re-run later stages without needing to re-run earlier ones.