GHCR container publishing (closes #17)#28
Merged
Conversation
Brings bdcd125's build-and-publish workflow onto main, building the combined CLI+web Dockerfile that landed in #24 (uv.lock-frozen deps, non-root, HEALTHCHECK). Publishes ghcr.io latest + sha tags with build provenance attestation on every push to main. Test job updated to uv sync --all-extras + uv run --no-sync pytest so the web/video test deps are actually present. Closes #17. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Luke Wilkinson <95864695+krakenhavoc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #17 — the publish workflow from @krakenhavoc's
feature/containerizationbranch (bdcd125), rebased onto main so it builds the combined CLI+web Dockerfile from #24 (uv.lock-frozen dependencies, non-root user, HEALTHCHECK) instead of carrying its own. On every push to main: tests → build → pushghcr.io/irobinson010/ascii-magic(latest+ commit-sha tags) with build provenance attestation.Two changes vs the original branch:
.dockerignore/README pieces are dropped — Color themes, captions, rain reveal, one-step color + PR #11 review fixes #24 already reconciled those (one image serving both the web GUI and one-shot CLI runs).uv sync --all-extrasand runsuv run --no-sync pytest— the originalpip install -e . && pip install pytestmisses the web/video test deps, and a bareuv runwould prune the extras.After merge, the README's
docker pull ghcr.io/irobinson010/ascii-magicexamples from the original branch become real — happy to add that section as a follow-up once the first image publishes.Test plan
🤖 Generated with Claude Code