GUI mp4 download + #11 review polish (reopens #30, #31)#33
Merged
Conversation
New POST /api/render/mp4 re-runs the video conversion and streams back an h264 mp4 with the source's audio muxed in - called only when the user clicks the new .mp4 download button, so the preview loop stays fast. The upload/convert core is shared with /api/render via _video_from_upload (which keeps the temp source alive for audio muxing). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- HTML player drop heads brightness-track like the ANSI/GIF sinks: 16 .hN classes computed with the same _cell_rgb blend, replacing the fixed full-bright head color. - Floyd-Steinberg dither inner loop runs on Python lists instead of per-element NumPy indexing: 3.5x faster at cols~400 (0.69s -> 0.20s on 1200x800), float64 accumulation (slightly more accurate on borderline pixels). - README documents the loop-seam behavior: drop positions loop seamlessly, glyph identities re-roll at the wrap. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #30 (auto-closed when its stacked base was deleted — gh's base-retarget API call fails silently on a Projects deprecation error) and carries #31, which merged into this branch rather than main for the same reason. Diff vs main = the mp4 encode-on-demand endpoint/button plus the #23 polish items. Both heads were CI-green (6/6). Closes #23.
🤖 Generated with Claude Code