Remove postcodes from Admin user search#784
Merged
Merged
Conversation
If postcode filtering was used with no other search terms, every single user was loaded from the database and we then attempted to filter them. This is not sustainable, and indeed did not work. We can better filter users offline if we need location-based subsets. This also allows us to remove all the apparatus for finding the lat-lon of postcodes we did not already have, too.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #784 +/- ##
==========================================
- Coverage 40.28% 40.12% -0.16%
==========================================
Files 546 543 -3
Lines 23794 23571 -223
Branches 2904 2867 -37
==========================================
- Hits 9585 9458 -127
+ Misses 13309 13229 -80
+ Partials 900 884 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
axlewin
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If postcode filtering was used with no other search terms, every single user was loaded from the database and we then attempted to filter them. This is not sustainable, and indeed did not work reliably. We can better filter users offline if we need location-based subsets.
This also allows us to remove all the apparatus for finding the lat-lon of postcodes we did not already have, too.