Skip to content

Add warning for URL invalid media sources#790

Open
machacekj0 wants to merge 1 commit into
mainfrom
feature/image-filename-warnings
Open

Add warning for URL invalid media sources#790
machacekj0 wants to merge 1 commit into
mainfrom
feature/image-filename-warnings

Conversation

@machacekj0
Copy link
Copy Markdown

Looking at filenames which Jetty rejected as illegal, for example kinetics_initial_rate_with_[b].svg. This adds a content error for the first invalid character in any bad filenames.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.30%. Comparing base (c5d1f1c) to head (0c424df).

Files with missing lines Patch % Lines
...ava/uk/ac/cam/cl/dtg/segue/etl/ContentIndexer.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #790      +/-   ##
==========================================
- Coverage   40.31%   40.30%   -0.01%     
==========================================
  Files         547      547              
  Lines       23773    23778       +5     
  Branches     2893     2894       +1     
==========================================
  Hits         9584     9584              
- Misses      13288    13293       +5     
  Partials      901      901              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@sjd210 sjd210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and works well when tested locally 👍 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants