Skip to content

Stop LLMFreeTextQuestions from generating choices-based content warnings#791

Open
sjd210 wants to merge 1 commit into
mainfrom
hotfix/remove-choices-warning
Open

Stop LLMFreeTextQuestions from generating choices-based content warnings#791
sjd210 wants to merge 1 commit into
mainfrom
hotfix/remove-choices-warning

Conversation

@sjd210
Copy link
Copy Markdown
Contributor

@sjd210 sjd210 commented May 19, 2026

isaacLLMFreeTextQuestions do not require a choices field, since they use a markScheme as its equivalent.
We should therefore not be giving a warning when the choices field is missing.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 40.31%. Comparing base (c5d1f1c) to head (f229d8f).

Files with missing lines Patch % Lines
...ava/uk/ac/cam/cl/dtg/segue/etl/ContentIndexer.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
- Coverage   40.31%   40.31%   -0.01%     
==========================================
  Files         547      547              
  Lines       23773    23773              
  Branches     2893     2893              
==========================================
- Hits         9584     9583       -1     
  Misses      13288    13288              
- Partials      901      902       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsharkey13
Copy link
Copy Markdown
Member

This feels like an acceptable stop-gap. But I would love to review the inheritance hierarchy here, and try to sort out the mess of IsaacQuestionBase -> ChoiceQuestion being back to front (particularly since we're removing the segue/isaac divide over time).

If IsaacLLMQuestion didn't extend ChoiceQuestion, it logically wouldn't be expected to have choices; but right now, things would break if it did not 😣

@sjd210
Copy link
Copy Markdown
Contributor Author

sjd210 commented May 19, 2026

@jsharkey13 I've also realised (to add to the mess) that we absolutely ARE expecting these questions to have the markScheme field, and that field must not be an empty list - so that should probably be its own content warning in lieu of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants