Bookmarks: Saving and listing

[jacbn]

An initial, feature-flagged set of changes to enable the saving and viewing of bookmarks on the My Bookmarks page (/bookmarks), accessible from the My Isaac nav.

Bookmarked questions currently appear as such on the question finder (there are no plans to allow filtering by bookmarks here, as this is too computationally expensive). A future PR will manage the changes to the deck builder.

We will also soon enable bookmarking of concepts, however we must consider adjustments to the concepts endpoint if we want to allow this in a similar manner to e.g. the question finder. This will take longer, and so is not part of this initial PR.

Requires isaacphysics/isaac-api#777 to run.

[codecov]

Codecov Report

❌ Patch coverage is 44.28571% with 78 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.72%. Comparing base (dc81ee6) to head (c744a94).
⚠️ Report is 45 commits behind head on main.

Files with missing lines	Patch %	Lines
src/app/components/pages/MyBookmarks.tsx	27.50%	29 Missing ⚠️
...components/elements/sidebar/MyBookmarksSidebar.tsx	22.22%	28 Missing ⚠️
src/app/components/elements/BookmarkButton.tsx	37.50%	10 Missing ⚠️
src/app/services/bookmarks.ts	56.25%	7 Missing ⚠️
src/app/state/slices/api/bookmarksApi.ts	62.50%	3 Missing ⚠️
...ents/elements/list-groups/AbstractListViewItem.tsx	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2098      +/-   ##
==========================================
- Coverage   43.72%   43.72%   -0.01%     
==========================================
  Files         584      589       +5     
  Lines       24768    24906     +138     
  Branches     7349     7379      +30     
==========================================
+ Hits        10831    10891      +60     
- Misses      13887    13965      +78     
  Partials       50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[axlewin]

This all works nicely on wide-ish screens, I think it's pretty much ready to go (behind a feature flag) once the backend's ready. Just noticed a couple of quirks on mobile:

• The "Search and filter" sidebar button gets duplicated on My bookmarks.
• There's no bookmark button on the question finder on mobile - is this intentional? (I realise there's not really room for it on particularly small screens).

A couple more minor thoughts:

• Could we adapt icon-bookmark for use as a hex icon on My bookmarks?
• The subject tag counts on My bookmarks don't update when a stage is selected (and vice-versa). I prefer this approach, but it is inconsistent with the other places where we have tag counts (/concepts & /practice_tests) - if we decide to go for non-updating counts, we should update the other places to be consistent.

[jacbn]

There's no bookmark button on the question finder on mobile

Yeah, I would like to add this but I can't find a consistent place for any kind of button for it. We could add an entirely new row underneath each question with a on-question-style button, but I think the wasted screen space from doing that when space is already at a premium on mobile isn't worth it. You can still save it from the page itself on mobile, so I'm okay leaving it out.

The subject tag counts on My bookmarks don't update when a stage is selected (and vice-versa).

Good spot, I hadn't noticed the inconsistency. I'm hesitant to change other pages without asking content, so maybe we push this through behind the feature flag and ask while they have a chance to play around with it?

Made a new page icon too, hope you like it! 🙈

[axlewin]

Made a new page icon too, hope you like it! 🙈

It's beautiful ;) I agree that the other two points don't need addressing right now, so LGTM!