Skip to content

Fix various cut-off focus outlines#2147

Open
sjd210 wants to merge 7 commits into
mainfrom
hotfix/isaac-focus-outline-cutoff
Open

Fix various cut-off focus outlines#2147
sjd210 wants to merge 7 commits into
mainfrom
hotfix/isaac-focus-outline-cutoff

Conversation

@sjd210
Copy link
Copy Markdown
Contributor

@sjd210 sjd210 commented May 11, 2026

Quite small:

  • Add equal padding and negative margin to the start of ALVI card text region so it is visually equivalent but has space for full outline around tags
  • Add margin to top of "See all books" link so that there is a minimum vertical distance between it and the above scrollbar, so the focus outline can't overlap with said scrollbar
    • (When there is already enough space, of course the margin has no effect)
  • Add small margin to top of event card column on subject landing pages to stop top of outline being cut off

Slightly larger (but still not very big):

Restructure book cards and subject landing page book container so that a) focus outlines are always visible (when book is focused), b) the spacing of books relative to the rest of the page is consistent, and c) the "View more books" button is properly centered when in a two-column layout - although I believe this is currently impossible.

Notably - in a full-width book layout, the left side of the book container was bleeding into the left margin of the page. It no longer does this, and instead respects the margin like in a book/event half-width layout.

sjd210 and others added 6 commits May 11, 2026 10:16
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.75%. Comparing base (c0062a2) to head (e4811ae).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/app/components/pages/SubjectLandingPage.tsx 0.00% 3 Missing ⚠️
src/app/components/pages/BooksOverview.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2147   +/-   ##
=======================================
  Coverage   43.75%   43.75%           
=======================================
  Files         593      593           
  Lines       25036    25036           
  Branches     7427     7427           
=======================================
  Hits        10954    10954           
  Misses      14032    14032           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…line-cutoff

[VRT] Update baselines for hotfix/isaac-focus-outline-cutoff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants