Allow dropdown inputs to be manually enabled for DnD questions for accessibility #2159
Draft
sjd210 wants to merge 22 commits into
Draft
Allow dropdown inputs to be manually enabled for DnD questions for accessibility #2159sjd210 wants to merge 22 commits into
sjd210 wants to merge 22 commits into
Conversation
This reverts commit 602c7f7.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2159 +/- ##
==========================================
- Coverage 43.75% 43.70% -0.05%
==========================================
Files 593 594 +1
Lines 25036 25084 +48
Branches 7427 7436 +9
==========================================
+ Hits 10954 10963 +9
- Misses 14032 14072 +40
+ Partials 50 49 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nput-setting [VRT] Update baselines for feature/non-dragging-input-setting
…nput-setting [VRT] Update baselines for feature/non-dragging-input-setting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an accessibility setting to "Enable non-dragging alternative inputs". For now this only affects cloze/drag-and-drop questions, but is defined broadly enough that we can use the same setting for other inputs in the future (e.g. depending on how we implement reorder question accessibility).
Also adds a
Dropdown/Drag and dropoverride toggle to all question pages containing these question types (in the same place as the context switcher on concept pages). The toggle is defaulted toDropdownonly for logged-in users who have the accessibility setting enabled or for mobile users (those atxsscreen or <=mdtouchscreen), and toDrag and dropin all other cases. Toggling will affect all drag and drop questions on the page. If manually toggled, this state will persist between screensizes - otherwise it will be reactive as before.Also requires https://github.com/isaacphysics/isaac-sops-config/pull/22 for new accessibility setting to work.