fix(unsaved): rework logic for inferring filetype for unsaved documents#24
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reworks the logic for inferring file types for unsaved documents in the VSCode treefmt extension. The main changes include refactoring the getExtensionForLanguage function to better handle language extension detection, extracting testable logic into separate functions, migrating from .eslintrc.json to ESLint flat config (eslint.config.mjs), adding comprehensive test coverage for the new logic, and upgrading dependencies.
- Improved stdin specifier inference for unsaved documents by preferring actual file extensions over bare filenames
- Refactored configuration loading logic into testable units
- Added comprehensive test suite with new test files and helpers
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/treefmtUtils.ts | Refactored filetype inference logic, extracted helper functions, added test exports |
| src/test/testContext.ts | New helper for creating test context with mock extension context |
| src/test/stdinTokenInference.test.ts | New tests for stdin token inference logic |
| src/test/pathAndExtensionHelpers.test.ts | New tests for path and extension helper functions |
| src/test/extension.test.ts | Reorganized test suite to use modular test registration |
| src/test/environment.test.ts | New tests for environment validation |
| src/test/commands.test.ts | New tests for command execution |
| src/test/commandResolution.test.ts | New tests for command resolution logic |
| eslint.config.mjs | Migration to ESLint v9 flat config (with issues) |
| .github/workflows/test.yaml | New CI workflow for running tests |
| .eslintrc.json | Removed legacy ESLint configuration |
| package.json | Updated dependencies and version bump |
| package-lock.json | Dependency updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.