Skip to content

fix separator buffer overflow in MRns_name_uncompress_list#12

Open
zayeem06 wants to merge 1 commit into
isc-projects:masterfrom
zayeem06:uncompress-list-sep-overflow
Open

fix separator buffer overflow in MRns_name_uncompress_list#12
zayeem06 wants to merge 1 commit into
isc-projects:masterfrom
zayeem06:uncompress-list-sep-overflow

Conversation

@zayeem06

Copy link
Copy Markdown

MRns_name_uncompress_list writes a comma separator and a trailing NUL between decoded names but only checks that one byte of the output buffer is still free, so when one name fills the buffer exactly and another name follows it writes the NUL one byte past the end. The path is reachable through concat_dclists when a client-supplied dhcp6.domain-search list is decoded into the fixed uncompbuf. The fix returns EMSGSIZE when fewer than two bytes remain for the separator; the added test in ns_name_test.c clobbers a sentinel byte just past the buffer on the unpatched code and is clean after, and the existing multi-name decode still round-trips.

@zayeem06

Copy link
Copy Markdown
Author

any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant