fix separator buffer overflow in MRns_name_uncompress_list#12
Open
zayeem06 wants to merge 1 commit into
Open
Conversation
Author
|
any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MRns_name_uncompress_list writes a comma separator and a trailing NUL between decoded names but only checks that one byte of the output buffer is still free, so when one name fills the buffer exactly and another name follows it writes the NUL one byte past the end. The path is reachable through concat_dclists when a client-supplied dhcp6.domain-search list is decoded into the fixed uncompbuf. The fix returns EMSGSIZE when fewer than two bytes remain for the separator; the added test in ns_name_test.c clobbers a sentinel byte just past the buffer on the unpatched code and is clean after, and the existing multi-name decode still round-trips.