Fix building of libweaver under MSYS2#18
Open
zulc22 wants to merge 2 commits intoisledecomp:masterfrom
Open
Conversation
Author
|
i found another issue with MSYS2. si::File doesn't properly get a handle for a binary file on MSYS2 (using UCRT64 GCC). it does a line-ending conversion. for some reason, SIEdit compiled via MSYS2 is able to extract files perfectly fine despite this. does SIEdit never use *Object->ExtractToFile()? |
…-error that CMake won't let me ignore when I embed the library
Contributor
|
In #38 I addressed |
madebr
reviewed
Oct 24, 2025
|
|
||
| DWORD m; | ||
| switch (s) { | ||
| default: |
Contributor
There was a problem hiding this comment.
This should not be needed. All cases are handled.
Lines 44 to 49 in 6da93b2
Author
There was a problem hiding this comment.
It's been a long time-- it shouldn't but I remember GCC under MSYS2 complaining that it wasn't handled anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOMINMAX is actually defined in MSYS2's headers, so I added #IFNDEF to guard defining NOMINMAX if it was already defined.