Support multiple dirs in YML source_root parameter#331
Draft
disinvite wants to merge 1 commit intoisledecomp:masterfrom
Draft
Support multiple dirs in YML source_root parameter#331disinvite wants to merge 1 commit intoisledecomp:masterfrom
source_root parameter#331disinvite wants to merge 1 commit intoisledecomp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #330. The supported formats will now be:
or
This field has been and still is required for reccmp. However: we now provide a default empty tuple for
source_root. This means that if the array is empty or thesource_rootkey is missing from the YML, this will passpydanticverification but fail in our code when you try to run with the target. (I added new tests that verify this.)Draft for now because I want to change the
source_rootproperty's internal name tosource_dirs, but ran out of time today.We don't have any tests on
Compare.from_targetto demonstrate that we walk each directory and dedupe potential nested paths. If it can work via mocks (i.e. without using real binary and PDB files) then I will add the tests.