WIP: Feature on click callback#31
Open
lfbn wants to merge 2 commits intoismarslomic:masterfrom
lfbn:feature/on-click-callback
Open
WIP: Feature on click callback#31lfbn wants to merge 2 commits intoismarslomic:masterfrom lfbn:feature/on-click-callback
lfbn wants to merge 2 commits intoismarslomic:masterfrom
lfbn:feature/on-click-callback
Conversation
Owner
|
Hi @lfbn! I think this is a good idea! Before I merge I would like your help on following:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ismarslomic adding this MR in WIP. What do you think of this feature? Useful? And this implementation? I've updated the method name that receives the on click, that should do the toggle and also call the received callback.