Bug Fix: Prevent 'a is undefined' error when removing layers#75
Open
jp584 wants to merge 1 commit intoismyrnow:gh-pagesfrom
Open
Bug Fix: Prevent 'a is undefined' error when removing layers#75jp584 wants to merge 1 commit intoismyrnow:gh-pagesfrom
jp584 wants to merge 1 commit intoismyrnow:gh-pagesfrom
Conversation
remove index and layer from _layer array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a layer is removed via the removeLayer method, the layer is set to undefined in the _layers array using the delete operator, which causes the array to become sparse. This leads to issues when iterating over the array in the _update() method, causing the error.
Check the green marked areas to see the error message, and the way the method is used