Dockerfile + logout redirect to home + vertical roles list in the header#60
Open
hormiai76 wants to merge 24 commits intoispyb:mainfrom
Open
Dockerfile + logout redirect to home + vertical roles list in the header#60hormiai76 wants to merge 24 commits intoispyb:mainfrom
hormiai76 wants to merge 24 commits intoispyb:mainfrom
Conversation
# Conflicts: # .gitlab-ci.yml # README.md
Using harbor in the dockerfile See merge request kits-ims/py-ispyb-ui!2
Using harbor See merge request kits-ims/py-ispyb-ui!3
Adding curl to fix npm install error See merge request kits-ims/py-ispyb-ui!4
Maxiv login/logout fix See merge request kits-ims/py-ispyb-ui!5
✅ Deploy Preview for py-ispyb ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Collaborator
|
Looks good, thanks! |
Collaborator
Collaborator
|
@hormiai76 A few comments:
|
Collaborator
Collaborator
Author
the .gitlab-ci.yml it's only needed here... I will put in my gitignore file so next time I will not push it on github but only in our internal repository. |
Collaborator
Author
|
I will add the netify in another MR I need to push this week |
mgaonach
approved these changes
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

List of changes