Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

add test for manager.#399

Open
morvencao wants to merge 1 commit intoistio:masterfrom
morvencao:br_add_test_for_manager
Open

add test for manager.#399
morvencao wants to merge 1 commit intoistio:masterfrom
morvencao:br_add_test_for_manager

Conversation

@morvencao
Copy link
Member

@morvencao morvencao commented Oct 17, 2019

No description provided.

@morvencao morvencao requested a review from a team as a code owner October 17, 2019 06:01
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 17, 2019
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 17, 2019
@morvencao
Copy link
Member Author

morvencao commented Oct 17, 2019 •
edited
Loading

@sdake @geeknoid I have added test for the controller and manager which needs kubebuilder binaries to get started, would you help to add kubebuilder binaries to the build-tools image.

The test is import because it can prevent the API changes that breaks the controller.

In my local env, I'm using kubebuilder v1.0.8 and everything is OK:

root@mcdev1:~/go/src/istio.io/operator# kubebuilder version
Version: version.Version{KubeBuilderVersion:"1.0.8", KubernetesVendor:"1.13.1", GitCommit:"1adf50ed107f5042d7472ba5ab50d5e1d357169d", BuildDate:"2019-01-25T23:14:29Z", GoOs:"unknown", GoArch:"unknown"}

@morvencao morvencao force-pushed the br_add_test_for_manager branch from 52c4ae1 to ad7d152 Compare October 21, 2019 14:12
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Nov 17, 2019
@elfinhe
Copy link
Member

elfinhe commented Dec 27, 2019

/retest

@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Dec 27, 2019
@istio-testing
Copy link

istio-testing commented Dec 27, 2019 •
edited
Loading

@morvencao: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test_operator ad7d152 link /test test_operator
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

elfinhe
elfinhe approved these changes Dec 27, 2019
View reviewed changes
Copy link
Member

@elfinhe elfinhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @sdake @howardjohn please consider adding kubebuilder into build-tools.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Feb 12, 2020
@istio-testing
Copy link

istio-testing commented Feb 12, 2020

@morvencao: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@elfinhe elfinhe elfinhe approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. needs-rebase Indicates a PR needs to be rebased before being merged size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@morvencao @elfinhe @istio-testing @googlebot @istio-policy-bot