set container of kubectl to 'uncaptured'#1664
set container of kubectl to 'uncaptured'#1664silenceshell wants to merge 1 commit intoistio:masterfrom
Conversation
|
😊 Welcome @silenceshell! This is either your first contribution to the Istio tools repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
303e710 to
fdfcaea
Compare
|
/retest |
stevenctl
left a comment
There was a problem hiding this comment.
I think what we actually want is to control this with kubectl.kubernetes.io/default-container
This is a good choice, my only concern is backward compatible, as |
Same problem here, |
When trying the perf/benchmark, I met a problem below.
The pods
fortioclient-54894c5758-htdgldefault container iscaptured, so the kubectl command will try to run fortio incapturedcontainer.Here is the log.
Maybe it is better to specify the container to run by kubectl, thus we won't exec fortio in wrong container.