Fix wrongly escaped regular expressions.#13
Open
rodrigoq wants to merge 1 commit intoitamart:masterfrom
Open
Conversation
Owner
|
Thanks. I will review the escaping of all regexp and fix for the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most regular expressions in the project are wrongly escaped. I fixed the ones that had the same error, but there are others. All preg_* functions that receive a variable as pattern parameter should be checked.
Without this fix there was a parsing error, to test set the name of a field something like: "A / B"