Implement file globbing support#186
Draft
simaoafonso-pwt wants to merge 4 commits intoiterative:mainfrom
Draft
Conversation
simaoafonso-pwt
force-pushed
the
issue/69-globs
branch
from
3cf0b3e to
201dcc2
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Move existing code to a common function.
This is tested locally in tcsh and bash, zsh is untested. There should not be any regressions, the test suite passes.
simaoafonso-pwt
force-pushed
the
issue/69-globs
branch
from
201dcc2 to
c60d0c8
Compare
Contributor
Author
|
Rebased to the latest version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is tested locally in tcsh and bash, zsh is untested.
There should not be any regressions, the test suite passes. We can bikeshed the name.
I did not add support for globbing folders, this doesn't seem to be supported in zsh. I also did not implement the sub-folder support (that is, showing all folders on the file glob completion, so you can descend the hierarchy) since this is only supported in bash. I accept this feature might be required, and are willing to implement it.
This is based on https://github.com/iterative/shtab/blob/main/examples/customcomplete.py#L11-L22.
For zsh, https://zsh-manual.netlify.app/completion-system mentions there's no support for globbing folders.
Fix #124 #69