Fix impurity density not being stored in SI units#3
Open
clarkindy wants to merge 1 commit intoiterorganization:developfrom
Open
Fix impurity density not being stored in SI units#3clarkindy wants to merge 1 commit intoiterorganization:developfrom
clarkindy wants to merge 1 commit intoiterorganization:developfrom
Conversation
This commit fixes wrong conversions for the five impurity ion densities, so that they are stored and retrieved as #/m3 instead of 1e19/m3. DINA GUI can load variables from DINA's *.dat input files and store them in the IDS format. However, while main ion density is correctly converted to SI units when it is stored in the IDS, impurity ion densities were not. Although iterorganization#2 mentions that there seems to be no treatment of tritium ion density, there is in fact code in dina_params_imas.f90 routine which converts and stores tritium ion density in SI units. It appears a few lines below the part treating deuterium ion density, where one would not normally expect it to be. Users will need to run DINA GUI again and re-generate input IDSs if they want to replicate previous DINA-PS runs. DINA inputs in *.dat files does not have to be changed. Closes: iterorganization#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes wrong conversions for the five impurity ion densities, so that they are stored and retrieved as #/m3 instead of 1e19/m3.
DINA GUI can load variables from DINA's *.dat input files and store them in the IDS format. However, while main ion density is correctly converted to SI units when it is stored in the IDS, impurity ion densities were not.
Although #2 mentions that there seems to be no treatment of tritium ion density, there is in fact code in dina_params_imas.f90 routine which converts and stores tritium ion density in SI units. It appears a few lines below the part treating deuterium ion density, where one would not normally expect it to be.
Users will need to run DINA GUI again and re-generate input IDSs if they want to replicate previous DINA-PS runs. DINA inputs in *.dat files does not have to be changed.
Closes: #2