You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @jwasikpsnc,
I would like to test your functionnality but I am not sure how to type the parameter interpolate_over.
Can you give me an example to test it ?
Thanks !
(there is testdb1 and testdb2)
If you want to add another URI to the list you just have to add another &interpolate_over=<uri> AFAIR, but i didn't checked it now.
You can always use swagger to create example curl request from parameters.
🙌
Hi @jwasikpsnc,
Thank you for the functionnality. I give you my feedback on the tests I have done from your example:
✅ Interpolation is working as expected for time coordinate
🛑 Coordinates order isn't preserved whereas it must be.
(We expect [dim1, dim2, porfiles_2d, time] but we have [time, profiles_2d, dim2, dim1])
🛑 Coordinates having dependencies (all except time) have an unexpected shape and incorrect values.
(For instance, profiles_2d shape is [4,2]. It didn't change but it should be [4, 4]. Moreover, it returns an array of shape [4]. On the end, the vector looks to not be interpolated as expected because we have: A == [0, 1] ; B == [0, 1, 2, 3] ; AB == [1, 2, 3, 4] whereas it should be [0, 1, 2, 3])
My tests are done with:
A = /data/plot_data?uri=imas:hdf5?path=/home/ITER/wasikj/Desktop/work/IBEX/testdb1#equilibrium/time_slice[:]/profiles_2d[:]/psi
B = /data/plot_data?uri=imas:hdf5?path=/home/ITER/wasikj/Desktop/work/IBEX/testdb2#equilibrium/time_slice[:]/profiles_2d[:]/psi
AB = /data/plot_data?uri=imas:hdf5?path=/home/ITER/wasikj/Desktop/work/IBEX/testdb1#equilibrium/time_slice[:]/profiles_2d[:]/psi
&interpolate_over=imas:hdf5?path=/home/ITER/wasikj/Desktop/work/IBEX/testdb2#equilibrium/time_slice[:]/profiles_2d[:]/psi
Hi @jwasikpsnc, I would like to test your functionnality but I am not sure how to type the parameter interpolate_over. Can you give me an example to test it ? Thanks !
@jwasikpsnc this question from the main dev of the frontend hints at an important lack of API documentation for the backend, this should be addressed please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First working version of data interpolation (not release-ready)
interpolate_overparameter to/data/plot_data/endpointPurpose of this PR is to merge functionality into develop, so the Frontend widgets can be created and integrated.