Skip to content

delete all uris: don't display 0#47

Merged
olivhoenen merged 1 commit intoiterorganization:developfrom
mfiaudrin-epsyl:bugfix/delete_all_btn_showing_0
Mar 24, 2026
Merged

delete all uris: don't display 0#47
olivhoenen merged 1 commit intoiterorganization:developfrom
mfiaudrin-epsyl:bugfix/delete_all_btn_showing_0

Conversation

@mfiaudrin-epsyl
Copy link
Collaborator

This fix resolve the '0' displayed whereas it shouldn't when the button to delete all URIs is hide.

It Closes #40 if @deepakmaroo confirm that there is no more bugs seen in #40.

@deepakmaroo
Copy link

Thank you @mfiaudrin-epsyl , I have tested and delete _all is workign fine.
The template is working fine for uri imas:hdf5?path=/work/imas/shared/imasdb/ITER/3/100003/1 and PlotKineticProfilesIbexState.json.
But same is not working for PlotScenarioIbexState.json and it appears blank workspace...

@mfiaudrin-epsyl
Copy link
Collaborator Author

mfiaudrin-epsyl commented Mar 18, 2026

Hi @deepakmaroo,
Thank you for your tests. I have reproduced it, I am on it

@mfiaudrin-epsyl
Copy link
Collaborator Author

@deepakmaroo, After some investigations, the bug you mention is caused by 2 bugs:

Once PR #45 has been merged and Issue #48 has been fixed and merged, the bug you mentioned should be resolved.

If you'd like, we can leave this PR open and close it once the rebase of both fixes has been completed, to ensure it's definitively fixed.

Copy link

@deepakmaroo deepakmaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains reasonable changes and poses no issues, so it can merged

@olivhoenen olivhoenen merged commit 871dfbe into iterorganization:develop Mar 24, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with add from template

3 participants