Integrated UDA-Plugins api listFilledPaths#41
Open
deepakmaroo wants to merge 4 commits intoiterorganization:developfrom
Open
Integrated UDA-Plugins api listFilledPaths#41deepakmaroo wants to merge 4 commits intoiterorganization:developfrom
deepakmaroo wants to merge 4 commits intoiterorganization:developfrom
Conversation
- API listFilledPaths returns the list of filled paths of given IDS
maarten-ic
reviewed
Mar 5, 2026
Contributor
maarten-ic
left a comment
maarten-ic
left a comment
There was a problem hiding this comment.
Hi @deepakmaroo, I had a quick look at the PR: can you have a look at the DRY comments below? Let me know if you have any questions
…-style array of strings
deepakmaroo
requested review from
olivhoenen and
prasad-sawantdesai
as code owners
…-style array of strings
maarten-ic
reviewed
Mar 6, 2026
Co-authored-by: Maarten Sebregts <110895564+maarten-ic@users.noreply.github.com>
paulotex
requested changes
Mar 23, 2026
| * @param path_list a pointer to the C-style array to create | ||
| * @param size a pointer to an integer to store the size of the created array | ||
| */ | ||
| void copy_stringvector_to_c_list(const std::vector<std::string>& paths, char*** path_list, int* size); |
Contributor
There was a problem hiding this comment.
I suggest size of type size_t*, not int*
| namespace utilities { | ||
|
|
||
| void copy_stringvector_to_c_list(const std::vector<std::string>& paths, char*** path_list, int* size) { | ||
| *size = static_cast<int>(paths.size()); |
Contributor
There was a problem hiding this comment.
If you agree with my suggestion above, this will be size_t.
casting is not needed here, and it can mask errors. So remove casting here.
Contributor
Author
There was a problem hiding this comment.
Thanks @paulotex for pointing out, I will test with required change and update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.