Remove explicit indices in coordinates, replaced with "(:)" syntax to note "any indices" (#157)#198
Merged
olivhoenen merged 4 commits intoiterorganization:developfrom Feb 3, 2026
Conversation
…case of a coordinate that is below an AoS and has the same size for all indices of this AoS
imbeauf
requested review from
DavidPCoster,
SimonPinches,
aksinghh,
medvedevsyu,
olivhoenen,
pankin,
qsthayashi,
simpla-fusion and
yegakjh
as code owners
maarten-ic
reviewed
Jan 16, 2026
Co-authored-by: Maarten Sebregts <110895564+maarten-ic@users.noreply.github.com>
DavidPCoster
approved these changes
Jan 18, 2026
medvedevsyu
approved these changes
Jan 18, 2026
qsthayashi
approved these changes
Jan 21, 2026
maarten-ic
approved these changes
Jan 22, 2026
Collaborator
Author
|
@simpla-fusion, @aksinghh , @pankin , @yegakjh , @SimonPinches , could you review this PR, please ? |
aksinghh
approved these changes
Feb 2, 2026
olivhoenen
approved these changes
Feb 3, 2026
SimonPinches
approved these changes
Feb 3, 2026
olivhoenen
changed the title
Collaborator
|
@imbeauf, before merging this one, could you describe the meaning of the newly introduced syntax in the documentation please? I guess https://github.com/iterorganization/IMAS-Data-Dictionary/blob/develop/docs/coordinates.rst would be a good place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://imas-data-dictionary--198.org.readthedocs.build/en/198/