[issue-203] Extension of the occurence_type identifier list for the P…#223
Open
imbeauf wants to merge 2 commits intoiterorganization:developfrom
Open
[issue-203] Extension of the occurence_type identifier list for the P…#223imbeauf wants to merge 2 commits intoiterorganization:developfrom
imbeauf wants to merge 2 commits intoiterorganization:developfrom
Conversation
imbeauf
requested review from
DavidPCoster,
SimonPinches,
aksinghh,
medvedevsyu,
olivhoenen,
pankin,
qsthayashi,
simpla-fusion and
yegakjh
as code owners
|
Yes, it is. Thank you. |
DavidPCoster
approved these changes
Mar 18, 2026
| <int name="prediction_fixed" description="Equilibrium prediction, fixed boundary">2</int> | ||
| <int name="prediction_free" description="Equilibrium prediction, free boundary">3</int> | ||
| <int name="mapping" description="Used for mapping equilibrium results from one grid type / resolution to another, or for including variables not present in the first set such as the calculation of magnetic field of other derived parameters">4</int> | ||
| <!-- Occurrence types for the plasma_core, plasma_source and plasma_transport IDSs --> |
Collaborator
There was a problem hiding this comment.
The nature of these types is different from those above. Those above indicate where the data has come from (equilibrium reconstruction or data mapping) whilst these describe what data is contained in this occurrence (core, edge or both). Do we foresee cases where it's necessary to communicate both of these bits of information?
Collaborator
Author
There was a problem hiding this comment.
For the moment, the listed occurrence types characterize different IDSs so no need for multiple occurrence_type per IDS.
If at some point we have a use case for that, we can change the structure and make it a vector of identifiers ...
paulotex
approved these changes
Mar 23, 2026
maarten-ic
reviewed
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…LASMA_* IDSs
Closes #203
May be of interest to @hrdoktorx
📚 Documentation preview 📚: https://imas-data-dictionary--223.org.readthedocs.build/en/223/