Use datapath with UDA when fetching IDS properties#39
Use datapath with UDA when fetching IDS properties#39olivhoenen merged 1 commit intoiterorganization:developfrom
Conversation
We request `ids_properties/homogeneous_time` and `ids_properties/version_put/data_dictionary` in two separate calls to the backend before actually getting all data. This is fine for local backends, but UDA would fetch the data three times: 1. When determining the DD version and if the IDS exists 2. When determining whether the IDS uses homogeneous time 3. When actually reading the data This commit adds a `datapath="ids_properties"` to the first two cases. This results in UDA only fetching the IDS properties in points 1 and 2. The full IDS is now requested once by UDA, in point 3.
DaanVanVugt
left a comment
There was a problem hiding this comment.
if using this argument with AL4 is there a reasonable behaviour? Or should we 'protect' our users from that by checking versions?
We only supply this argument when using the UDA backend, which is not relevant to AL4 IIRC. |
|
Actually, I think at this point it's impossible to use I'll create a ticket to remove legacy AL4 support from the code |
|
I agree that we do not need to have compatibility with the AL4 lowlevel API (cleaning can be done in a forthcoming PR before the next release). |
We request
ids_properties/homogeneous_timeandids_properties/version_put/data_dictionaryin two separate calls to the backend before actually getting all data. This is fine for local backends, but UDA would fetch the data three times:This commit adds a
datapath="ids_properties"to the first two cases. This results in UDA only fetching the IDS properties in points 1 and 2. The full IDS is now requested once by UDA, in point 3.