Modify lazy loading test to generate random data without complex numbers.#49
Merged
olivhoenen merged 1 commit intoiterorganization:developfrom Jun 10, 2025
Merged
Conversation
Nush395
requested review from
maarten-ic,
olivhoenen and
prasad-sawantdesai
as code owners
Nush395
commented
Jun 9, 2025
| def run_lazy_loading_distributions_random(dbentry): | ||
| ids = IDSFactory().new("distributions") | ||
| fill_consistent(ids) | ||
| fill_consistent(ids, skip_complex=True) |
Contributor
Author
There was a problem hiding this comment.
alternative to this could be to change the default skip_complex value in the fill_consistent helper and then explicitly have a pattern elsewhere of
skipIf with skip_complex=False
maarten-ic
approved these changes
Jun 10, 2025
Collaborator
maarten-ic
left a comment
maarten-ic
left a comment
There was a problem hiding this comment.
LGTM! Complex numbers aren't essential to this test
olivhoenen
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposed solution to allow for netCDF4<1.7.0 support for the tests. If there is a better way to handle this please let me know.