Merged
Conversation
…ng between DD 3 and 4. Fixes #31.
Select `imas_core` when the URI starts with `imas:`, otherwise use the netCDF backend. This change allows using NCZarr [1] as storage engine (when it is enabled in the netCDF4 python module) by using `file://`, `s3://` or `https://` style URIs. [1] https://docs.unidata.ucar.edu/nug/current/nczarr_head.html
Pytest runs successfully with numpy 2.x, so we should be able to remove this restriction.
We request `ids_properties/homogeneous_time` and `ids_properties/version_put/data_dictionary` in two separate calls to the backend before actually getting all data. This is fine for local backends, but UDA would fetch the data three times: 1. When determining the DD version and if the IDS exists 2. When determining whether the IDS uses homogeneous time 3. When actually reading the data This commit adds a `datapath="ids_properties"` to the first two cases. This results in UDA only fetching the IDS properties in points 1 and 2. The full IDS is now requested once by UDA, in point 3.
This reverts commit 33e6b7e.
…ert_ids call This prevents polluting the output of the CLI `imas convert` and explict `imas.convert_ids` calls with lots of repeated warnings.
Co-authored-by: Maarten Sebregts <110895564+maarten-ic@users.noreply.github.com>
The Data Dictionary definitions are now provided by the `imas-data-dictionaries` package.
maarten-ic
reviewed
Jun 18, 2025
Collaborator
maarten-ic
left a comment
maarten-ic
left a comment
There was a problem hiding this comment.
Thanks Olivier!
Some small comments on the readme changes.
allow using nzcarr for storing netCDF format
The commit that did this was also reverted later. I'd suggest to remove this item from the changelog.
Co-authored-by: Maarten Sebregts <110895564+maarten-ic@users.noreply.github.com>
maarten-ic
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
imas-data-dictionariespackage (remove internal build via saxonche)