Skip to content

Update python versions used in github actions#63

Merged
olivhoenen merged 4 commits intoiterorganization:developfrom
maarten-ic:feature/update-ci-versions
Aug 26, 2025
Merged

Update python versions used in github actions#63
olivhoenen merged 4 commits intoiterorganization:developfrom
maarten-ic:feature/update-ci-versions

Conversation

@maarten-ic
Copy link
Collaborator

  • Remove Python 3.8 (which is already end-of-life for ~10 months) and add Python 3.13.
  • Update OS to ubuntu-latest instead of a fixed version

- Remove Python 3.8 (which is already end-of-life for ~10 months) and add Python 3.13.
- Update OS to `ubuntu-latest` instead of a fixed version
Copy link
Collaborator

@SimonPinches SimonPinches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite 3.8 being end-of-life, I'd still maintain the testing for it (and 3.7) since I'm not sure we can guarantee all our collaborators have moved on and according to our pyproject.toml file, we're still compatible with `>=3.7". Or is this now not possible using GitHub actions?

@maarten-ic
Copy link
Collaborator Author

Despite 3.8 being end-of-life, I'd still maintain the testing for it (and 3.7) since I'm not sure we can guarantee all our collaborators have moved on and according to our pyproject.toml file, we're still compatible with `>=3.7". Or is this now not possible using GitHub actions?

It's (at this moment) still possible to test with Python 3.8 on github actions. For Python 3.7 I'll test if that works.

For MUSCLE3, the biggest problem with testing for outdated Python versions was that, at some point, dependencies were no longer available on PyPI for the older Python version. We can just choose to disable tests for old python versions when this becomes an issue.

Python 3.7 is not available on `ubuntu-latest`.
(build) dependencies are not available for Python 3.7 on PyPI
@maarten-ic
Copy link
Collaborator Author

Update: Python 3.7 cannot be tested as is on github actions, because the build dependency (setuptools_scm>8) is not available on PyPI for Python 3.7.

Copy link
Collaborator

@SimonPinches SimonPinches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@olivhoenen olivhoenen merged commit bcd47fe into iterorganization:develop Aug 26, 2025
12 checks passed
@maarten-ic maarten-ic deleted the feature/update-ci-versions branch August 26, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants