Move logged message from critical to warning when imas_core is not available#75
Merged
olivhoenen merged 1 commit intoiterorganization:developfrom Sep 30, 2025
Merged
Conversation
olivhoenen
requested review from
maarten-ic and
prasad-sawantdesai
as code owners
prasad-sawantdesai
approved these changes
Sep 30, 2025
Collaborator
Author
|
Was discussed in the past with @DaanVanVugt, it was thought that functionalities of IMAS-Python were too much impacted to lower the criticality of the message when imas_core is missing. Nevertheless, it seems that the false-positive impression from this critical message is counter productive, so I've decided to follow @Nush395 advise. |
maarten-ic
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #74