Update hints / log messages when using the UDA backend#76
Merged
olivhoenen merged 6 commits intoiterorganization:developfrom Oct 13, 2025
Merged
Update hints / log messages when using the UDA backend#76olivhoenen merged 6 commits intoiterorganization:developfrom
olivhoenen merged 6 commits intoiterorganization:developfrom
Conversation
Lowlevel access layer version 4.x is not supported by IMAS-Python. See also iterorganization#40.
maarten-ic
requested review from
olivhoenen and
prasad-sawantdesai
as code owners
olivhoenen
reviewed
Oct 7, 2025
| raise RuntimeError("Lazy loading is not supported by the ASCII backend.") | ||
| if self.backend == "uda": | ||
| # cache_mode=none doesn't work right now, so the warning won't recommend it | ||
| # See: https://jira.iter.org/browse/IMAS-5644 |
Collaborator
There was a problem hiding this comment.
Is this still the case with imas-core develop? @deepakmaroo
Collaborator
|
The doc shall also be updated:
|
maarten-ic
commented
Oct 13, 2025
Comment on lines
+100
to
+102
| .. [#cache_mode_none] The option ``cache_mode=none`` requires IMAS Core version 5.5.1 or | ||
| newer, and a remote UDA server with `IMAS UDA-Plugins | ||
| <https://github.com/iterorganization/UDA-Plugins>`__ version 1.7.0 or newer. |
Collaborator
Author
There was a problem hiding this comment.
@olivhoenen @deepakmaroo can you please check if my assumptions are valid?
- https://jira.iter.org/browse/IMAS-5644 will be part of IMAS Core version 5.5.1 (since 5.5.0 is released, and that still has issues).
- Since cache_mode=none only works for the test UDA server (and not the production one) I assumed that the next UDA plugins release is required.
There was a problem hiding this comment.
You are correct @maarten-ic , IMAS core v5.5.1 will be release for UDA backend fixed and UDA-Plugins v1.7.0 will be release for complex number support. Documentation looks good to me.
olivhoenen
requested review from
deepakmaroo and
olivhoenen
and removed request for
prasad-sawantdesai
olivhoenen
approved these changes
Oct 13, 2025
Collaborator
olivhoenen
left a comment
olivhoenen
left a comment
There was a problem hiding this comment.
Looks good to be me now!
deepakmaroo
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And remove unused logic for supporting AL4.
The original purpose of these changes were to:
Implemented in commit e8a5dde
However, when implementing the second point, it was easier after removing some old and unused AL4 code. So I decided to complete that work with the follow-up commits. Closes #40