Add WTF message to list of ignored level values#3
Open
ljbkusters wants to merge 1 commit into
Open
Conversation
When clearing logs, an extra WTF log type action chip appears. When clicking on the action chip (or any other action chip) it disappears, making it likely that this is a bug. In the Log class located in lib/src/entity/log.dart there is an attribute called usedLevelValues. In it there is a list of excluded log values which are not to be printed to the screen as Action chips. However, when using the LoggerScreenPrinter.clear() method, the level count map is checked using this Log.usedLevelValues attribute, which was missing an excluder for the WTF message type. Now that the Level.wtf has been added to the list of excluded levels, the WTF message no longer appears when clearing the logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When clearing logs, an extra WTF log type action chip appears. When clicking on the action chip (or any other action chip) it disappears, making it likely that this is a bug.
In the Log class located in lib/src/entity/log.dart there is an attribute called usedLevelValues. In it there is a list of excluded log values which are not to be printed to the screen as Action chips. However, when using the LoggerScreenPrinter.clear() method, the level count map is checked using this Log.usedLevelValues attribute, which was missing an excluder for the WTF message type.
Now that the Level.wtf has been added to the list of excluded levels, the WTF message no longer appears when clearing the logs.