add cd and ls commands#12
Open
mk17ru wants to merge 3 commits into
Open
Conversation
added 2 commits
November 18, 2024 21:19
gkashin
reviewed
Nov 25, 2024
| * @author mk17ru | ||
| * @since 0.0.3 | ||
| */ | ||
| class LsCommand : Command { |
Contributor
There was a problem hiding this comment.
Не уверен, нужна ли обработка флагов команды? -l, -b, -c…
Если нет, то все отлично.
Contributor
There was a problem hiding this comment.
По заданию кажется не обязательным, а так согласен, всё отлично.
gkashin
approved these changes
Nov 25, 2024
gkashin
left a comment
gkashin
left a comment
Contributor
There was a problem hiding this comment.
Единственный возникший вопрос – нужна ли обработка флагов команды ls?
В противном случае реализации команд вписываются в нашу кодовую базу хорошо. Существующие тесты проходят. Новая функциональность также протестирована. LGTM
| @@ -0,0 +1,39 @@ | |||
| ### Фидбек по архитектуре CLI-приложения | |||
Contributor
There was a problem hiding this comment.
Спасибо за такой детальный фидбек!
Contributor
|
@sibmaks Что думаешь? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.