refactor: improve scope management with Disposable pattern#6
Open
nickBes wants to merge 1 commit intoits-elad:mainfrom
Open
refactor: improve scope management with Disposable pattern#6nickBes wants to merge 1 commit intoits-elad:mainfrom
nickBes wants to merge 1 commit intoits-elad:mainfrom
Conversation
nickBes
commented
Mar 11, 2026
nickBes
commented
- Removed unnecessary pop methods for query and CTE scopes, replacing them with a Disposable pattern to ensure proper scope cleanup.
- Updated documentation to reflect changes in scope management strategy.
- Simplified the visitQuery and visitQueryNoWith methods for better readability and maintainability.
- Enhanced type safety and clarity in the handling of CTEs and query terms.
- Added TypeScript compiler options to support ES2023 features.
- Removed unnecessary pop methods for query and CTE scopes, replacing them with a Disposable pattern to ensure proper scope cleanup. - Updated documentation to reflect changes in scope management strategy. - Simplified the visitQuery and visitQueryNoWith methods for better readability and maintainability. - Enhanced type safety and clarity in the handling of CTEs and query terms. - Added TypeScript compiler options to support ES2023 features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.