Changed to abstract class#1
Open
Josh-Beck wants to merge 2 commits into
Open
Conversation
its-emile
reviewed
Apr 27, 2025
Owner
its-emile
left a comment
its-emile
left a comment
There was a problem hiding this comment.
in the latest commit I removed the 1-shot example instructions altogether, leaving it completely open ended (the example was not intended to require developers to provide a call sequence parameter).
Would love your input if there is another component in this PR that would be beneficial to adopt?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I envision the use of schema based validation in an abstract class that defines a flow of tool calls, each of which could be its own MCP tool call. I made a rough version of it here, happy to chat about it further.