Install browser verification runbook#40
Draft
itsablabla wants to merge 2 commits into
Draft
Conversation
Run-on: Niteshift
There was a problem hiding this comment.
Non-blocking feedback (1)
- Add an explicit fallback when
/tmp/browser-preview.jsonis absent — docs/runbooks/niteshift-browser-verification.md#L32-L35
The prerequisites say a known local app URL is also valid, but the current snippet alwaysrequires/tmp/browser-preview.jsonand will fail when that file is missing. Add a small fallback so local-only tasks can still run the flow (for example, check for the file first and otherwise setAPP_URLto a documented local URL).
If you want, I can apply this update directly; reply with please fix 1.
Run-on: Niteshift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Demo
Screenshots
🌒 Run on Niteshift: View Task