Skip to content

ci cd#132

Open
jarjk wants to merge 10 commits intoitsjunetime:mainfrom
jarjk:ci-cd
Open

ci cd#132
jarjk wants to merge 10 commits intoitsjunetime:mainfrom
jarjk:ci-cd

Conversation

@jarjk
Copy link

@jarjk jarjk commented Jan 28, 2026

fixes #10

@jarjk jarjk force-pushed the ci-cd branch 2 times, most recently from ec2a2cb to cc9d034 Compare January 28, 2026 12:55
@jarjk
Copy link
Author

jarjk commented Jan 28, 2026

check out runs on my fork:

p.s.: please fix windows compilation

@jarjk jarjk marked this pull request as ready for review January 28, 2026 16:03
Copy link
Owner

@itsjunetime itsjunetime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally like this, and really do appreciate the work you've put into this. It's definitely something tdf would benefit from.

I'm not certain I like the tip-release workflow, so if you'd be able to explain it a bit more or what's useful about it, I'd appreciate it.

Also, I've obviously gotta figure out windows compilation. I don't have a windows machine, but I'll take a look at that and hopefully get it working soon.

files: release-artifacts/*
prerelease: ${{ contains(github.ref, 'alpha') || contains(github.ref, 'beta') || contains(github.ref, 'rc') }}

tip-release:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the usefulness or purpose of this workflow - does it just overwrite the tip tag with the latest commit every time a new commit is pushed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, there's a release, that's always updated on commits to main

eg:

jarjk and others added 2 commits January 30, 2026 12:08
Co-authored-by: June <61218022+itsjunetime@users.noreply.github.com>
Co-authored-by: June <61218022+itsjunetime@users.noreply.github.com>
@itsjunetime
Copy link
Owner

itsjunetime commented Jan 31, 2026

Could you update the Cargo.toml to point at ratatui-image revision 521d6c1389c6ae783953485e9654f1db91652f0b? I think I fixed the windows issue there, maybe windows CI will work now

jarjk and others added 2 commits February 1, 2026 17:37
Co-authored-by: June <61218022+itsjunetime@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create GitHub releases

2 participants