Conversation
- adds puppeteer dependency
- ensures links are cleared from storage when viewing chrome:// url - handles in-browser testing of chrome extension
- sign-in link opens in a new tab/window - removes extraneous console output - adds ids to sign-up / sign-in links
- tests logged-out behavior to ensure sign-in/sign-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds initial tests using Puppeteer / Chromium.
Limits
There are some limits to testing Chrome extensions, including how content scripts are handled (via the documentation).
In order to test bookmark behavior in the extension, a local server will need to be running. This will require some future rework to allow the server endpoint to be configurable.