fix: Reuse existing unattached remotepy SG instead of failing#88
Merged
Conversation
When a remotepy-{name} security group already existed in the VPC but
wasn't attached to the instance (e.g. after replacing an instance),
sg add would fail with InvalidGroup.Duplicate. Now find_or_create_remotepy_sg
checks for unattached SGs in the VPC before attempting to create a new one.
- Clear all inbound rules from orphaned SGs before reattaching so they behave like freshly created ones (prevents stale IP whitelists) - Warn when multiple SGs with the same name exist in the VPC - Handle InvalidGroup.Duplicate race condition when two processes try to create the same SG simultaneously - Use aws_error_code attribute instead of string matching for reliability - Add comprehensive tests for all new paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #85.
find_or_create_remotepy_sg()now checks for an existingremotepy-{name}security group in the VPC before attempting to create a new oneTest plan
test_finds_existing_unattached_sg_in_vpc— verifies the VPC lookup and attach pathtest_creates_and_attaches_when_missing— now also mocks the VPC lookup returning empty results