Skip to content

fix: dereference symlinks in CLI tarballs#191

Open
riley0227 wants to merge 1 commit intomainfrom
fix/tarball-symlinks
Open

fix: dereference symlinks in CLI tarballs#191
riley0227 wants to merge 1 commit intomainfrom
fix/tarball-symlinks

Conversation

@riley0227
Copy link
Copy Markdown
Contributor

Summary

  • cp -r preserves npm workspace symlinks in node_modules, which end up in the release tarballs
  • macOS tar refuses to extract files through symlinks (Cannot extract through symlink errors), breaking installs on Mac
  • Changed to cp -rL across all 5 platform packaging steps to dereference symlinks into real files

Test plan

  • Merge and cut a new release
  • Download the darwin-arm64 tarball and verify tar xzf extracts cleanly
  • Run the install script on a clean Mac

cp -r preserves npm workspace symlinks in node_modules, which causes
macOS tar to fail with 'Cannot extract through symlink' errors.
Use cp -rL to dereference symlinks so tarballs contain real files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant