Skip to content

Changed Query Display to Split Pane, query box now remembers last expression - #2

Open
Avinm wants to merge 1 commit into
j--wong:masterfrom
Avinm:master
Open

Changed Query Display to Split Pane, query box now remembers last expression#2
Avinm wants to merge 1 commit into
j--wong:masterfrom
Avinm:master

Conversation

@Avinm

@Avinm Avinm commented May 27, 2018

Copy link
Copy Markdown

No description provided.

@j--wong

j--wong commented Apr 27, 2019

Copy link
Copy Markdown
Owner

Hi @Avinm, thanks for the PR. I do have plans to introduce split pane for displaying results. If you're still interested in getting your PR merged, would you mind creating a separate ResultViewer such as SplitPanelResultViewer instead of modifying the OutputChannelResultViewer? That way, we can later have config to allow user to switch between them? Also, please add unit tests for the new result viewer implementation. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants