Skip to content

fix(deps): pin source generator Roslyn common package#354

Closed
j-d-ha wants to merge 1 commit into
mainfrom
fix/deps-pin-roslyn-500
Closed

fix(deps): pin source generator Roslyn common package#354
j-d-ha wants to merge 1 commit into
mainfrom
fix/deps-pin-roslyn-500

Conversation

@j-d-ha
Copy link
Copy Markdown
Owner

@j-d-ha j-d-ha commented May 20, 2026

🚀 Pull Request

📋 Summary

Pins the source generator's compiler-facing Roslyn references to 5.0.0 so the generator remains loadable by compiler hosts using Roslyn 5.0. The existing Microsoft.CodeAnalysis.CSharp exact pin is kept, and Microsoft.CodeAnalysis.Common is now pinned and referenced directly to make the dependency floor explicit.


✅ Checklist

  • My changes build cleanly
  • I’ve added/updated relevant tests
  • I’ve added/updated documentation or README
  • I’ve tested the changes locally (if applicable)

💬 Notes for Reviewers

Validation run:

  • DOTNET_NOLOGO=1 dotnet restore src/MinimalLambda.SourceGenerators/MinimalLambda.SourceGenerators.csproj
  • dotnet list src/MinimalLambda.SourceGenerators/MinimalLambda.SourceGenerators.csproj package --include-transitive confirmed Microsoft.CodeAnalysis.Common and Microsoft.CodeAnalysis.CSharp resolve to 5.0.0, while Microsoft.CodeAnalysis.Analyzers remains at 5.3.0.
  • DOTNET_NOLOGO=1 dotnet build src/MinimalLambda.SourceGenerators/MinimalLambda.SourceGenerators.csproj --no-restore
  • MCP test runner: tests/MinimalLambda.SourceGenerators.UnitTests/MinimalLambda.SourceGenerators.UnitTests.csproj passed 95 tests.

task format was intentionally not completed per follow-up instruction to focus on the package change.

Copy link
Copy Markdown
Owner Author

j-d-ha commented May 20, 2026

Closing this as redundant after checking the restore graph and compiled source generator assembly references.

Microsoft.CodeAnalysis.CSharp is already pinned to [5.0.0] on main, and that package transitively pins Microsoft.CodeAnalysis.Common to [5.0.0]. The built MinimalLambda.SourceGenerators.dll references Microsoft.CodeAnalysis 5.0.0.0 and Microsoft.CodeAnalysis.CSharp 5.0.0.0 already.

Microsoft.CodeAnalysis.Analyzers is a private development analyzer package used while building this repo; it is not referenced by the shipped source generator DLL and is not the consumer compiler-load issue.

@j-d-ha j-d-ha closed this May 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
- Coverage   87.52%   87.38%   -0.15%     
==========================================
  Files         113      113              
  Lines        2814     2814              
  Branches      351      351              
==========================================
- Hits         2463     2459       -4     
- Misses        250      254       +4     
  Partials      101      101              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 692a65c...b75e03e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant