fix(deps): pin source generator Roslyn common package#354
Conversation
|
Closing this as redundant after checking the restore graph and compiled source generator assembly references.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #354 +/- ##
==========================================
- Coverage 87.52% 87.38% -0.15%
==========================================
Files 113 113
Lines 2814 2814
Branches 351 351
==========================================
- Hits 2463 2459 -4
- Misses 250 254 +4
Partials 101 101 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
🚀 Pull Request
📋 Summary
Pins the source generator's compiler-facing Roslyn references to
5.0.0so the generator remains loadable by compiler hosts using Roslyn 5.0. The existingMicrosoft.CodeAnalysis.CSharpexact pin is kept, andMicrosoft.CodeAnalysis.Commonis now pinned and referenced directly to make the dependency floor explicit.✅ Checklist
💬 Notes for Reviewers
Validation run:
DOTNET_NOLOGO=1 dotnet restore src/MinimalLambda.SourceGenerators/MinimalLambda.SourceGenerators.csprojdotnet list src/MinimalLambda.SourceGenerators/MinimalLambda.SourceGenerators.csproj package --include-transitiveconfirmedMicrosoft.CodeAnalysis.CommonandMicrosoft.CodeAnalysis.CSharpresolve to5.0.0, whileMicrosoft.CodeAnalysis.Analyzersremains at5.3.0.DOTNET_NOLOGO=1 dotnet build src/MinimalLambda.SourceGenerators/MinimalLambda.SourceGenerators.csproj --no-restoretests/MinimalLambda.SourceGenerators.UnitTests/MinimalLambda.SourceGenerators.UnitTests.csprojpassed 95 tests.task formatwas intentionally not completed per follow-up instruction to focus on the package change.