Handle missing blobs in diff snapshots by j178 · Pull Request #2211 · j178/prek

j178 · 2026-06-13T12:30:58Z

codecov · 2026-06-13T12:32:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.52%. Comparing base (6166275) to head (95ac041).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2211      +/-   ##
==========================================
- Coverage   92.59%   92.52%   -0.07%     
==========================================
  Files         125      125              
  Lines       26587    26698     +111     
==========================================
+ Hits        24617    24702      +85     
- Misses       1970     1996      +26

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0ece60469e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

This PR adjusts prek’s internal “before/after” diff snapshotting so prek run --all-files can operate in CI environments with a partial .git directory (missing blob objects), addressing the failure mode described in #2208.

Changes:

Relax git diff snapshot error handling to allow continuing when git diff exits non-zero but still provides usable stdout.
Add an integration test that simulates missing blob objects and asserts --all-files remains usable when hooks leave the tree clean.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/prek/src/git.rs	Makes `get_diff` tolerate non-zero `git diff` exit codes so `--all-files` can proceed in slim `.git` environments.
crates/prek/tests/skipped_hooks.rs	Adds a regression test that deletes a blob object and verifies diff snapshotting doesn’t hard-fail `--all-files`.

prek-ci-bot · 2026-06-13T12:38:55Z

📦 Cargo Bloat Comparison

Binary size change: +0.38% (26.5 MiB → 26.6 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.2%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_encrypt_avx512
 1.2%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_decrypt_avx512
 0.4%   0.7%  95.4KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  90.8KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  85.1KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.3%   0.6%  79.4KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  49.6KiB              prek prek::run::{{closure}}
 0.2%   0.4%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.3%  44.6KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.2%   0.3%  43.8KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.2%  32.0KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  31.4KiB             prek? <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  29.4KiB     granit_parser granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.3KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::RemoteHook>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.1KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  24.8KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::LocalHook>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  22.9KiB     granit_parser granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
41.8%  86.0%  11.1MiB                   And 24248 smaller methods. Use -n N to show more.
48.6% 100.0%  12.9MiB                   .text section size, the file size is 26.6MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.2%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_encrypt_avx512
 1.2%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_decrypt_avx512
 0.4%   0.7%  95.4KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  90.8KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  85.1KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.3%   0.6%  78.9KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  49.6KiB              prek prek::run::{{closure}}
 0.2%   0.4%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.3%  44.6KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.2%   0.3%  43.6KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.2%  32.0KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  31.1KiB             prek? <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  29.4KiB     granit_parser granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.3KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::RemoteHook>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.1KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  24.8KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::LocalHook>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  22.9KiB     granit_parser granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
41.8%  86.0%  11.1MiB                   And 24242 smaller methods. Use -n N to show more.
48.6% 100.0%  12.9MiB                   .text section size, the file size is 26.5MiB

prek-ci-bot · 2026-06-13T12:38:55Z

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment

OS: Linux 6.17.0-1018-azure
CPU: 4 cores
prek version: prek 0.4.4+46 (14ac26d 2026-06-13)
Rust version: rustc 1.96.0 (ac68faa20 2026-05-25)
Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

`prek --version`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base --version`	2.4 ± 0.1	2.3	2.7	1.01 ± 0.05
`prek-head --version`	2.4 ± 0.1	2.2	2.7	1.00

`prek list`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base list`	9.5 ± 0.1	9.3	9.8	1.02 ± 0.02
`prek-head list`	9.3 ± 0.1	9.1	9.8	1.00

`prek validate-config .pre-commit-config.yaml`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base validate-config .pre-commit-config.yaml`	3.4 ± 0.0	3.3	3.5	1.06 ± 0.02
`prek-head validate-config .pre-commit-config.yaml`	3.2 ± 0.1	3.1	3.3	1.00

`prek sample-config`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base sample-config`	2.8 ± 0.0	2.7	2.9	1.07 ± 0.03
`prek-head sample-config`	2.6 ± 0.1	2.5	2.7	1.00

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

`prek run --all-files (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	76.4 ± 3.3	72.1	82.6	1.05 ± 0.06
`prek-head run --all-files`	73.0 ± 2.3	70.2	77.3	1.00

`prek run --all-files (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	75.5 ± 3.0	71.3	80.5	1.02 ± 0.05
`prek-head run --all-files`	73.9 ± 2.5	70.6	78.4	1.00

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

`prek run --all-files (full builtin hook suite)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	73.5 ± 2.6	70.0	79.8	1.00
`prek-head run --all-files`	74.2 ± 2.4	69.7	78.9	1.01 ± 0.05

Individual Hook Performance

Benchmarking each hook individually on the test repo:

`prek run trailing-whitespace --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run trailing-whitespace --all-files`	20.4 ± 0.4	19.4	21.5	1.00
`prek-head run trailing-whitespace --all-files`	20.5 ± 0.4	19.9	21.6	1.00 ± 0.03

`prek run end-of-file-fixer --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run end-of-file-fixer --all-files`	26.0 ± 1.8	23.9	30.4	1.00
`prek-head run end-of-file-fixer --all-files`	26.5 ± 2.2	23.6	30.8	1.02 ± 0.11

`prek run check-json --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-json --all-files`	8.2 ± 0.2	7.9	8.6	1.02 ± 0.04
`prek-head run check-json --all-files`	8.1 ± 0.3	7.6	8.5	1.00

`prek run check-yaml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-yaml --all-files`	8.0 ± 0.3	7.8	9.4	1.05 ± 0.04
`prek-head run check-yaml --all-files`	7.7 ± 0.1	7.5	8.0	1.00

`prek run check-toml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-toml --all-files`	8.1 ± 0.3	7.6	9.2	1.00
`prek-head run check-toml --all-files`	8.3 ± 1.2	7.4	12.8	1.03 ± 0.16

`prek run check-xml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-xml --all-files`	8.3 ± 0.3	7.8	9.0	1.04 ± 0.05
`prek-head run check-xml --all-files`	8.0 ± 0.3	7.5	8.6	1.00

`prek run detect-private-key --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run detect-private-key --all-files`	13.7 ± 1.3	11.9	16.7	1.02 ± 0.14
`prek-head run detect-private-key --all-files`	13.4 ± 1.2	11.8	16.5	1.00

`prek run fix-byte-order-marker --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run fix-byte-order-marker --all-files`	18.8 ± 0.7	17.3	20.1	1.04 ± 0.06
`prek-head run fix-byte-order-marker --all-files`	18.1 ± 0.8	16.9	19.4	1.00

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

`prek install-hooks (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	4.8 ± 0.0	4.8	4.9	1.04 ± 0.01
`prek-head install-hooks`	4.6 ± 0.0	4.6	4.6	1.00

`prek install-hooks (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	4.8 ± 0.1	4.8	5.0	1.04 ± 0.02
`prek-head install-hooks`	4.6 ± 0.0	4.6	4.7	1.00

File Filtering/Scoping Performance

Testing different file selection modes:

`prek run (staged files only)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run`	39.0 ± 0.9	38.0	40.5	1.00
`prek-head run`	41.4 ± 7.8	38.2	74.1	1.06 ± 0.20

`prek run --files '*.json' (specific file type)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --files '*.json'`	8.6 ± 0.1	8.5	8.7	1.03 ± 0.01
`prek-head run --files '*.json'`	8.4 ± 0.1	8.3	8.5	1.00

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

`prek run --dry-run --all-files (measures init overhead)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --dry-run --all-files`	7.4 ± 0.1	7.2	7.6	1.04 ± 0.02
`prek-head run --dry-run --all-files`	7.1 ± 0.1	7.0	7.4	1.00

Meta Hooks Performance

Benchmarking meta hooks separately:

`prek run check-hooks-apply --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-hooks-apply --all-files`	12.8 ± 0.1	12.7	13.0	1.04 ± 0.11
`prek-head run check-hooks-apply --all-files`	12.3 ± 1.3	11.1	15.0	1.00

`prek run check-useless-excludes --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-useless-excludes --all-files`	11.4 ± 0.1	11.2	11.5	1.02 ± 0.01
`prek-head run check-useless-excludes --all-files`	11.1 ± 0.1	11.0	11.5	1.00

`prek run identity --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run identity --all-files`	10.8 ± 0.1	10.7	10.9	1.02 ± 0.01
`prek-head run identity --all-files`	10.6 ± 0.1	10.5	10.8	1.00

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

j178 added the bug Something isn't working label Jun 13, 2026 — with ChatGPT Codex Connector

j178 marked this pull request as ready for review June 13, 2026 12:31

Copilot AI review requested due to automatic review settings June 13, 2026 12:31

Copilot started reviewing on behalf of j178 June 13, 2026 12:32 View session

chatgpt-codex-connector Bot reviewed Jun 13, 2026

View reviewed changes

Comment thread crates/prek/src/git.rs

Copilot AI reviewed Jun 13, 2026

View reviewed changes

Comment thread crates/prek/src/git.rs

j178 force-pushed the fix-2208 branch from 0ece604 to c63d1ec Compare June 13, 2026 12:38

j178 force-pushed the fix-2208 branch from c63d1ec to 6268364 Compare June 13, 2026 12:49

Copilot AI review requested due to automatic review settings June 13, 2026 12:49

Copilot started reviewing on behalf of j178 June 13, 2026 12:50 View session

Copilot AI reviewed Jun 13, 2026

View reviewed changes

Comment thread crates/prek/src/git.rs

Comment thread crates/prek/tests/skipped_hooks.rs

Handle missing blobs in diff snapshots

95ac041

j178 force-pushed the fix-2208 branch from 6268364 to 95ac041 Compare June 13, 2026 12:56

j178 merged commit 8adaed9 into master Jun 13, 2026
34 checks passed

j178 deleted the fix-2208 branch June 13, 2026 13:09

Uh oh!

Conversation

j178 commented Jun 13, 2026

Uh oh!

codecov Bot commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

prek-ci-bot Bot commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Cargo Bloat Comparison

Head Branch Results

Base Branch Results

Uh oh!

prek-ci-bot Bot commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡️ Hyperfine Benchmarks

prek --version

prek list

prek validate-config .pre-commit-config.yaml

prek sample-config

prek run --all-files (cold - no cache)

prek run --all-files (warm - with cache)

prek run --all-files (full builtin hook suite)

prek run trailing-whitespace --all-files

prek run end-of-file-fixer --all-files

prek run check-json --all-files

prek run check-yaml --all-files

prek run check-toml --all-files

prek run check-xml --all-files

prek run detect-private-key --all-files

prek run fix-byte-order-marker --all-files

prek install-hooks (cold - no cache)

prek install-hooks (warm - with cache)

prek run (staged files only)

prek run --files '*.json' (specific file type)

prek run --dry-run --all-files (measures init overhead)

prek run check-hooks-apply --all-files

prek run check-useless-excludes --all-files

prek run identity --all-files

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Jun 13, 2026 •

edited

Loading

prek-ci-bot Bot commented Jun 13, 2026 •

edited

Loading

prek-ci-bot Bot commented Jun 13, 2026 •

edited

Loading

`prek --version`

`prek list`

`prek validate-config .pre-commit-config.yaml`

`prek sample-config`

`prek run --all-files (cold - no cache)`

`prek run --all-files (warm - with cache)`

`prek run --all-files (full builtin hook suite)`

`prek run trailing-whitespace --all-files`

`prek run end-of-file-fixer --all-files`

`prek run check-json --all-files`

`prek run check-yaml --all-files`

`prek run check-toml --all-files`

`prek run check-xml --all-files`

`prek run detect-private-key --all-files`

`prek run fix-byte-order-marker --all-files`

`prek install-hooks (cold - no cache)`

`prek install-hooks (warm - with cache)`

`prek run (staged files only)`

`prek run --files '*.json' (specific file type)`

`prek run --dry-run --all-files (measures init overhead)`

`prek run check-hooks-apply --all-files`

`prek run check-useless-excludes --all-files`

`prek run identity --all-files`