Removed dependacy on stathat.py, updated to work with Python 3#4
Open
tommarmstrong wants to merge 1 commit into
Open
Removed dependacy on stathat.py, updated to work with Python 3#4tommarmstrong wants to merge 1 commit into
tommarmstrong wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
Ran into problems getting this to work with Python 3.5 and so I changed a few things to make it work. Thought I should PR it in case you were interested.
The dependancy Stathat.py that was being wrapped by this package has been removed as the latest version isn't available from PyPi and the version that is available has a bug that means it won't run. In any case, the functionality provided by stathat was just the ability to send two API calls to stathat and so I have reimplemented them using requests.
Plus there was a minor change to the Queue module (renamed to use a lowercase q) that I fixed up.
Not sure about compatibility with Python 2.7 but I think it would be easy enough to make it work.
Tomm :)