build: fix wheel built on windows not working on linux#32
Draft
yaseen-mowzer-octave wants to merge 1 commit into
Draft
build: fix wheel built on windows not working on linux#32yaseen-mowzer-octave wants to merge 1 commit into
yaseen-mowzer-octave wants to merge 1 commit into
Conversation
If you build a wheel of windows it will unconditionally add pywin32 and
mozprocess as dependencies. But you cannot install these packages on
linux.
Instead of using `if sys.platform.startswith("win32")` which is
evaluated at build time (not install time!), use environment markers as
documented in
https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#platform-specific-dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you build a wheel of windows it will unconditionally add pywin32 and mozprocess as dependencies. But you cannot install these packages on linux.
Instead of using
if sys.platform.startswith("win32")which is evaluated at build time (not install time!), use environment markers as documented in https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#platform-specific-dependenciesIn Draft because I haven't done any testing.